Support multiple definitions: Locals #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet another case for #6 This supports two cases: - Definitions across multiple files - The case where a local is used in the second file. We were currently using the initial stack to find the bind for that var. Across files, that doesn't work, we have to work with the stack where the var is being used
julienduchesne
changed the title
julienduchesne
added a commit
that referenced
this pull request
Feb 17, 2022
Whenever a binary operator was in the chain, it would make all fields to not be found further down the line
This supports find fields in constructs like this:
```
{
my_field+: (import 'test') + (import 'test2')
}
```
Note: the tests are getting pretty intense. I'm planning a refactor once I've got the cases I want working. I'll probably set up some benchmarking as well, see if I can find some low-hanging fruits for performance improvements
This builds upon #30 and #31
Issue: #6
julienduchesne
added a commit
that referenced
this pull request
Feb 17, 2022
julienduchesne
added a commit
that referenced
this pull request
Feb 17, 2022
Whenever a binary operator was in the chain, it would make all fields to not be found further down the line
This supports find fields in constructs like this:
```
{
my_field+: (import 'test') + (import 'test2')
}
```
Note: the tests are getting pretty intense. I'm planning a refactor once I've got the cases I want working. I'll probably set up some benchmarking as well, see if I can find some low-hanging fruits for performance improvements
This builds upon #30 and #31
Issue: #6
julienduchesne
added a commit
that referenced
this pull request
Feb 17, 2022
Whenever a binary operator was in the chain, it would make all fields to not be found further down the line
This supports find fields in constructs like this:
```
{
my_field+: (import 'test') + (import 'test2')
}
```
Note: the tests are getting pretty intense. I'm planning a refactor once I've got the cases I want working. I'll probably set up some benchmarking as well, see if I can find some low-hanging fruits for performance improvements
This builds upon #30 and #31
Issue: #6
zzehring
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another case for #6
This supports two cases: