grafana-builder: Use custom all value to avoid massive regexes in queries. #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries. Signed-off-by: Tom Wilkie <[email protected]>
gouthamve
reviewed
Feb 17, 2021
Signed-off-by: Tom Wilkie <[email protected]>
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
1 task
bboreham
added a commit
to grafana/cortex-jsonnet
that referenced
this pull request
Aug 18, 2021
Brings in the following changes: - Use default as a picker value for datasource variable grafana/jsonnet-libs#204 - allow table link in new tab grafana/jsonnet-libs#238 - allow setting a default datasource grafana/jsonnet-libs#301 - Add textPanel grafana/jsonnet-libs#341 - make status code label name overrideable in qpsPanel grafana/jsonnet-libs#397 - use $__rate_interval over $__interval grafana/jsonnet-libs#401 - Set shared tooltip to false by default grafana/jsonnet-libs#458 - Use custom 'all' value to avoid massive regexes in queries. grafana/jsonnet-libs#469 https://github.com/grafana/jsonnet-libs/commits/master/grafana-builder/
yvrhdn
pushed a commit
to yvrhdn/jsonnet-libs
that referenced
this pull request
Nov 26, 2021
grafana#469 changed the default allValue for addMultiTemplate from `null` to `'.+'`. I want to make it configurable. Reason: we use addMultiTemplate to add a namespace dropdown in the tempo-mixin: https://github.com/grafana/tempo/blob/a1a95b35e15741061fc7119256aaeab78083dfbc/operations/tempo-mixin/dashboard-utils.libsonnet#L28 https://github.com/grafana/tempo/blob/a1a95b35e15741061fc7119256aaeab78083dfbc/operations/tempo-mixin/yamls/tempo-resources.json#L1873-L1900 This dropdown is populated with the namespaces a Tempo cluster is running in. The current behaviour (with `allValue: '.+'`) is confusing, because selecting All in the dropdown ends up querying all namespaces. The previous behaviour (with `allValue: null`) only queries the namespaces that are returned by the query. The reason we got confused is that in our dashboard you can select a cluster and if you know there is only 1 Tempo namespace in that cluster you kind of expect to only see data from that namespace. But with `allValue: '.+'` you get data from all namespaces in that cluster. So we're mistakenly looking at queriers from a non-Tempo cluster and wondering why CPU was so high.
tomwilkie
pushed a commit
that referenced
this pull request
Nov 26, 2021
#469 changed the default allValue for addMultiTemplate from `null` to `'.+'`. I want to make it configurable. Reason: we use addMultiTemplate to add a namespace dropdown in the tempo-mixin: https://github.com/grafana/tempo/blob/a1a95b35e15741061fc7119256aaeab78083dfbc/operations/tempo-mixin/dashboard-utils.libsonnet#L28 https://github.com/grafana/tempo/blob/a1a95b35e15741061fc7119256aaeab78083dfbc/operations/tempo-mixin/yamls/tempo-resources.json#L1873-L1900 This dropdown is populated with the namespaces a Tempo cluster is running in. The current behaviour (with `allValue: '.+'`) is confusing, because selecting All in the dropdown ends up querying all namespaces. The previous behaviour (with `allValue: null`) only queries the namespaces that are returned by the query. The reason we got confused is that in our dashboard you can select a cluster and if you know there is only 1 Tempo namespace in that cluster you kind of expect to only see data from that namespace. But with `allValue: '.+'` you get data from all namespaces in that cluster. So we're mistakenly looking at queriers from a non-Tempo cluster and wondering why CPU was so high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wilkie [email protected]