Skip to content

Mixins: draw graphs at full resolution #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Mixins: draw graphs at full resolution #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion envoy-mixin/dashboards.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ local template = import 'grafonnet/template.libsonnet';
{
expr: 'sum by (status) (label_replace(rate(' + selector + '[$__rate_interval]), "status", "${1}xx", "envoy_response_code_class", "(.*)"))',
format: 'time_series',
intervalFactor: 2,
legendFormat: '{{status}}',
refId: 'A',
step: 10,
Expand Down
7 changes: 0 additions & 7 deletions grafana-builder/grafana.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,6 @@
legendLink: legendLink,
expr: ql.q,
format: 'time_series',
intervalFactor: 2,
legendFormat: ql.l,
}
for ql in qsandls
Expand All @@ -305,7 +304,6 @@
expr: query,
format: 'time_series',
instant: true,
intervalFactor: 2,
refId: 'A',
},
],
Expand Down Expand Up @@ -368,7 +366,6 @@
expr: qs[i],
format: 'table',
instant: true,
intervalFactor: 2,
legendFormat: '',
refId: std.char(65 + i),
}
Expand Down Expand Up @@ -445,7 +442,6 @@
"status", "${1}", "%s", "([a-zA-Z]+)"))
||| % [selector, statusLabelName, statusLabelName],
format: 'time_series',
intervalFactor: 2,
legendFormat: '{{status}}',
refId: 'A',
},
Expand All @@ -458,21 +454,18 @@
{
expr: 'histogram_quantile(0.99, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
format: 'time_series',
intervalFactor: 2,
legendFormat: '99th Percentile',
refId: 'A',
},
{
expr: 'histogram_quantile(0.50, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
format: 'time_series',
intervalFactor: 2,
legendFormat: '50th Percentile',
refId: 'B',
},
{
expr: 'sum(rate(%s_sum%s[$__rate_interval])) * %s / sum(rate(%s_count%s[$__rate_interval]))' % [metricName, selector, multiplier, metricName, selector],
format: 'time_series',
intervalFactor: 2,
legendFormat: 'Average',
refId: 'C',
},
Expand Down
2 changes: 0 additions & 2 deletions jaeger-mixin/dashboards.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,13 @@ local g = (import 'grafana-builder/grafana.libsonnet') + {
{
expr: expr(selectorErr),
format: 'time_series',
intervalFactor: 2,
legendFormat: 'error',
refId: 'A',
step: 10,
},
{
expr: expr(selectorTotal) + ' - ' + expr(selectorErr),
format: 'time_series',
intervalFactor: 2,
legendFormat: 'success',
refId: 'B',
step: 10,
Expand Down
3 changes: 0 additions & 3 deletions mixin-utils/utils.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
sumBy: sumByHisto,
},
format: 'time_series',
intervalFactor: 2,
legendFormat: '%(legend)s99th percentile' % legend,
refId: 'A',
step: 10,
Expand All @@ -80,7 +79,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
sumBy: sumByHisto,
},
format: 'time_series',
intervalFactor: 2,
legendFormat: '%(legend)s50th percentile' % legend,
refId: 'B',
step: 10,
Expand All @@ -94,7 +92,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
sumBy: sumBy,
},
format: 'time_series',
intervalFactor: 2,
legendFormat: '%(legend)sAverage' % legend,
refId: 'C',
step: 10,
Expand Down