Skip to content

fix(operator): move authorization RBAC to dedicated cluster_scoped controller #16712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix(operator): move authorization RBAC to dedicated cluster_scoped controller #16712

wants to merge 10 commits into from
+311 −250

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Mar 12, 2025 •
edited
Loading

What this PR does / why we need it:

Depends on both:

Which issue(s) this PR fixes:
https://issues.redhat.com/browse/LOG-6083

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 12, 2025
@JoaoBraveCoding JoaoBraveCoding force-pushed the LOG-6083 branch 2 times, most recently from 47351a3 to f8310e1 Compare March 13, 2025 17:17
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Apr 3, 2025
@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review April 3, 2025 13:30
@JoaoBraveCoding JoaoBraveCoding requested review from a team, periklis and xperimental as code owners April 3, 2025 13:30
xperimental
xperimental reviewed Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just reviewing as a "dry run" (mostly code style), because my network is currently limited.

@JoaoBraveCoding JoaoBraveCoding deleted the LOG-6083 branch September 29, 2025 10:50
@JoaoBraveCoding JoaoBraveCoding restored the LOG-6083 branch September 29, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xperimental xperimental xperimental left review comments

@periklis periklis Awaiting requested review from periklis periklis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

sig/operator size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoaoBraveCoding @xperimental