Add CODEOWNERS #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
tomwilkie
approved these changes
Jul 14, 2021
pstibrany
added a commit
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Peter Štibraný <[email protected]>
radudd
added a commit
to radudd/mimir
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Dimitar Dimitrov <[email protected]>
krajorama
added a commit
that referenced
this pull request
Sep 29, 2022
# This is the 1st commit message: Add MaxTotalQueryLength and fill it from MaxQueryLength if 0 Add the ability to define a higher total query length limit on the frontend , compared to the current shared limit between querier and query-frontend. Ref: grafana/mimir-squad#889 Signed-off-by: György Krajcsovits <[email protected]> # Conflicts: # CHANGELOG.md # This is the commit message #2: Update runbook # This is the commit message #3: Update pkg/util/validation/limits.go Co-authored-by: Nick Pillitteri <[email protected]> # This is the commit message #4: Rename store.max-total-query-length to query-frontend... Signed-off-by: György Krajcsovits <[email protected]>
gotjosh
added a commit
that referenced
this pull request
Jun 25, 2024
This PR introduces two subtle but important changes (it's mostly a proposal and feel free to argue on this): 1. We now wait until we stop _all_ of the managers. This is important, because managers don't stop rule evaluation that are in-flight, so we'll wait until we finish any sort of rule group evaluation before considering the "tenant removed". 2. Also, once we're done with rule evaluation we _actually_ stop the notifiers. Notifiers weren't stopped before which was mostly a good thing (as we would always make sure that any alerts were getting flushed). All in all, #1 is mostly up for discussion. However, I think #2 should go in as it makes the behaviour explicit. Signed-off-by: gotjosh <[email protected]>
4 tasks
gotjosh
added a commit
that referenced
this pull request
Jun 28, 2024
This PR introduces two subtle but important changes (it's mostly a proposal and feel free to argue on this): 1. We now wait until we stop _all_ of the managers. This is important, because managers don't stop rule evaluation that are in-flight, so we'll wait until we finish any sort of rule group evaluation before considering the "tenant removed". 2. Also, once we're done with rule evaluation we _actually_ stop the notifiers. Notifiers weren't stopped before which was mostly a good thing (as we would always make sure that any alerts were getting flushed). All in all, #1 is mostly up for discussion. However, I think #2 should go in as it makes the behaviour explicit. Signed-off-by: gotjosh <[email protected]>
dimitarvdimitrov
added a commit
that referenced
this pull request
Sep 11, 2025
� This is the 1st commit message: Update prometheus vendor to include IndexLookupPlannerFunc support Vendor mimir-prometheus v1.8.2-0.20250904101001-6716d356946a which includes the new IndexLookupPlannerFunc field in TSDB Options. This enables per-block planner creation for implementing block-specific statistics. This is part 1 of the per-block statistics implementation. � This is the commit message #2: Vendor mimir-prometheus PR #973: Add IndexLookupPlannerFunc support This vendors grafana/mimir-prometheus#973 which adds IndexLookupPlannerFunc support to TSDB, enabling per-block index lookup planning. Changes: - Add IndexLookupPlannerFunc type to TSDB Options - Remove legacy IndexLookupPlanner field entirely - Update all call sites to use function-based approach - Enable block-specific planner creation similar to BlockChunkQuerierFunc This is foundation work for implementing per-block statistics in Mimir ingester, replacing the current approach of using head statistics for all blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
What's the sentiment about adding
CODEOWNERSto enforce requiring a review from 1 of @grafana/mimir-maintainers ?Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]