Skip to content

Conversation

clue
Copy link
Member

@clue clue commented Oct 30, 2022

HHVM does not support PHP anymore and regularly causes our builds to fail, so no reason to keep legacy HHVM support around anymore.

Builds on top of #32, #51 and graphp/graph#211

@clue clue added this to the v0.9.0 milestone Oct 30, 2022
@clue clue requested a review from SimonFrings October 30, 2022 14:10
@clue
Copy link
Member Author

clue commented Oct 30, 2022

The build error is unrelated and being addressed in #51. On top of this, #51 currently fails because the HHVM build fails which is being addressed in this PR. My vote would be to merge #51 as is and then rebase this PR before merging.

@clue
Copy link
Member Author

clue commented Oct 31, 2022

Rebased now that #51 has been merged :shipit:

@SimonFrings SimonFrings merged commit 2693893 into graphp:0.9.x Nov 2, 2022
@SimonFrings SimonFrings deleted the drop-hhvm branch November 2, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants