Skip to content
This repository was archived by the owner on Feb 23, 2023. It is now read-only.

Add JSON utils for returning kinds, valid utf8, and kinds to strings #116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

davekay100
Copy link
Contributor

Found these here: https://github.com/nanspro/kauri-subgraph/blob/master/src/util.ts

  • Untested. Opening the PR to make us aware of it
  • I am found of them all, except kindToString() - not too sure if this is useful enough to be in the library
  • isValidUTF8() looks great, but I am unaware of how it currently works
  • Would be nice to add in for asBigInt() and asI32()

What do you guys think? @Jannis @leoyvens

@davekay100 davekay100 requested review from Jannis and leoyvens June 8, 2020 00:13
@davekay100 davekay100 force-pushed the dave/add-json-utils branch from 49490ae to 2d7768c Compare June 8, 2020 00:14
@leoyvens
Copy link
Collaborator

The as* APIs for JSON seem useful, but they should be put directly under JSONValue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants