Skip to content

Allow GraphQLFloat to be represented by float64 #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2016

Conversation

sogko
Copy link
Member

@sogko sogko commented Jun 2, 2016

This PR addresses #130 and depends on PR #123

Relevant commit changeset:
c7fc493 Updated graphql.Float coercion

  • if value type is explicitly float32, return float32
  • if value type is explicitly float64, return float64
  • if value type is int, return float64
  • if value type is string, use strconv.ParseFloat() to return float64
  • for everything else, use system-default

- if value type is explicitly `float32`, return `float32`
- if value type is explicitly `float64`, return `float64`
- if value type is `string`, return `float64`
- for everything else, use system-default

Addresses issue graphql-go#130
@sogko sogko changed the title Sogko/float64 Allow GraphQLFloat to be represented by float64 Jun 2, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 90.754% when pulling c7fc493 on sogko:sogko/float64 into a5cf5f2 on graphql-go:master.

@sogko sogko added this to the v0.5.0 milestone Jun 11, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.754% when pulling 3582a63 on sogko:sogko/float64 into 4a8d417 on graphql-go:master.

@sogko sogko merged commit 491504a into graphql-go:master Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants