Skip to content

Conversation

theguild-bot
Copy link
Collaborator

@theguild-bot theguild-bot commented Feb 4, 2025

The examples converted from E2E tests have changed in d6b81d4.

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-graphql-ws 2.0.1-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-mesh/fusion-runtime 0.10.32-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway 1.9.3-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-opentelemetry 1.3.40-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-mesh/plugin-prometheus 1.3.28-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-hive/gateway-runtime 1.4.12-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎
@graphql-mesh/transport-ws 1.0.1-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16 npm ↗︎ unpkg ↗︎

Copy link
Contributor

coderabbitai bot commented Feb 4, 2025

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the gateway dependency to version 1.9.2 across several sample projects.
    • Upgraded the mesh transport dependency to version 1.0.0 in one sample for improved protocol support.

Walkthrough

This pull request updates the dependency versions in multiple package.json files across various example projects. The version of the @graphql-hive/gateway dependency is incremented from ^1.9.1 to ^1.9.2 in all specified files. Additionally, one file upgrades the @graphql-mesh/transport-ws dependency from ^0.4.16 to ^1.0.0. No other changes are introduced in these files.

Changes

File(s) Changed Change Summary
examples/{apq-subgraphs, extra-fields, federation-example, federation-mixed, file-upload, hmac-auth-https, interface-additional-resolvers, json-schema-subscriptions, openapi-additional-resolvers, openapi-arg-rename, openapi-javascript-wiki, openapi-subscriptions, operation-field-permissions, programmatic-batching, subscriptions-with-transforms, type-merging-batching}/package.json Updated @graphql-hive/gateway dependency from ^1.9.1 to ^1.9.2.
examples/federation-subscriptions-passthrough/package.json Updated @graphql-hive/gateway from ^1.9.1 to ^1.9.2 and @graphql-mesh/transport-ws from ^0.4.16 to ^1.0.0.

Possibly related PRs

  • Upcoming Release Changes #575: Involves a similar update to the @graphql-hive/gateway dependency version, though addressing a different version change.
  • Upcoming Release Changes #583: Contains dependency version updates to @graphql-hive/gateway across multiple packages, directly related to the updates seen in this PR.

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9d20682 and 6ece969.

⛔ Files ignored due to path filters (34)
  • examples/apq-subgraphs/example.tar.gz is excluded by !**/*.gz
  • examples/apq-subgraphs/package-lock.json is excluded by !**/package-lock.json
  • examples/extra-fields/example.tar.gz is excluded by !**/*.gz
  • examples/extra-fields/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-example/example.tar.gz is excluded by !**/*.gz
  • examples/federation-example/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-mixed/example.tar.gz is excluded by !**/*.gz
  • examples/federation-mixed/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-subscriptions-passthrough/example.tar.gz is excluded by !**/*.gz
  • examples/federation-subscriptions-passthrough/package-lock.json is excluded by !**/package-lock.json
  • examples/file-upload/example.tar.gz is excluded by !**/*.gz
  • examples/file-upload/package-lock.json is excluded by !**/package-lock.json
  • examples/hmac-auth-https/example.tar.gz is excluded by !**/*.gz
  • examples/hmac-auth-https/package-lock.json is excluded by !**/package-lock.json
  • examples/interface-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/interface-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/json-schema-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/json-schema-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-arg-rename/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-arg-rename/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-javascript-wiki/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-javascript-wiki/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/operation-field-permissions/example.tar.gz is excluded by !**/*.gz
  • examples/operation-field-permissions/package-lock.json is excluded by !**/package-lock.json
  • examples/programmatic-batching/example.tar.gz is excluded by !**/*.gz
  • examples/programmatic-batching/package-lock.json is excluded by !**/package-lock.json
  • examples/subscriptions-with-transforms/example.tar.gz is excluded by !**/*.gz
  • examples/subscriptions-with-transforms/package-lock.json is excluded by !**/package-lock.json
  • examples/type-merging-batching/example.tar.gz is excluded by !**/*.gz
  • examples/type-merging-batching/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • examples/apq-subgraphs/package.json (1 hunks)
  • examples/extra-fields/package.json (1 hunks)
  • examples/federation-example/package.json (1 hunks)
  • examples/federation-mixed/package.json (1 hunks)
  • examples/federation-subscriptions-passthrough/package.json (2 hunks)
  • examples/file-upload/package.json (1 hunks)
  • examples/hmac-auth-https/package.json (1 hunks)
  • examples/interface-additional-resolvers/package.json (1 hunks)
  • examples/json-schema-subscriptions/package.json (1 hunks)
  • examples/openapi-additional-resolvers/package.json (1 hunks)
  • examples/openapi-arg-rename/package.json (1 hunks)
  • examples/openapi-javascript-wiki/package.json (1 hunks)
  • examples/openapi-subscriptions/package.json (1 hunks)
  • examples/operation-field-permissions/package.json (1 hunks)
  • examples/programmatic-batching/package.json (1 hunks)
  • examples/subscriptions-with-transforms/package.json (1 hunks)
  • examples/type-merging-batching/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (17)
  • examples/extra-fields/package.json
  • examples/hmac-auth-https/package.json
  • examples/openapi-arg-rename/package.json
  • examples/file-upload/package.json
  • examples/programmatic-batching/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/json-schema-subscriptions/package.json
  • examples/openapi-subscriptions/package.json
  • examples/federation-mixed/package.json
  • examples/federation-subscriptions-passthrough/package.json
  • examples/federation-example/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/operation-field-permissions/package.json
  • examples/type-merging-batching/package.json
  • examples/apq-subgraphs/package.json
  • examples/interface-additional-resolvers/package.json
⏰ Context from checks skipped due to timeout of 90000ms (23)
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Unit / Node v22
  • GitHub Check: Unit / Bun
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Unit / Node v18
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Leaks / Node v22
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: Leaks / Node v20
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Bundle
  • GitHub Check: Build
  • GitHub Check: Analyze (javascript-typescript)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
examples/federation-subscriptions-passthrough/package.json (1)

1-30: Missing Linear Issue Reference
The PR description does not include a reference to a Linear issue (e.g., "GW-..."). For improved traceability and compliance with our process, please link the appropriate Linear issue in the PR description.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53a8ac2 and 9d20682.

⛔ Files ignored due to path filters (34)
  • examples/apq-subgraphs/example.tar.gz is excluded by !**/*.gz
  • examples/apq-subgraphs/package-lock.json is excluded by !**/package-lock.json
  • examples/extra-fields/example.tar.gz is excluded by !**/*.gz
  • examples/extra-fields/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-example/example.tar.gz is excluded by !**/*.gz
  • examples/federation-example/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-mixed/example.tar.gz is excluded by !**/*.gz
  • examples/federation-mixed/package-lock.json is excluded by !**/package-lock.json
  • examples/federation-subscriptions-passthrough/example.tar.gz is excluded by !**/*.gz
  • examples/federation-subscriptions-passthrough/package-lock.json is excluded by !**/package-lock.json
  • examples/file-upload/example.tar.gz is excluded by !**/*.gz
  • examples/file-upload/package-lock.json is excluded by !**/package-lock.json
  • examples/hmac-auth-https/example.tar.gz is excluded by !**/*.gz
  • examples/hmac-auth-https/package-lock.json is excluded by !**/package-lock.json
  • examples/interface-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/interface-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/json-schema-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/json-schema-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-additional-resolvers/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-additional-resolvers/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-arg-rename/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-arg-rename/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-javascript-wiki/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-javascript-wiki/package-lock.json is excluded by !**/package-lock.json
  • examples/openapi-subscriptions/example.tar.gz is excluded by !**/*.gz
  • examples/openapi-subscriptions/package-lock.json is excluded by !**/package-lock.json
  • examples/operation-field-permissions/example.tar.gz is excluded by !**/*.gz
  • examples/operation-field-permissions/package-lock.json is excluded by !**/package-lock.json
  • examples/programmatic-batching/example.tar.gz is excluded by !**/*.gz
  • examples/programmatic-batching/package-lock.json is excluded by !**/package-lock.json
  • examples/subscriptions-with-transforms/example.tar.gz is excluded by !**/*.gz
  • examples/subscriptions-with-transforms/package-lock.json is excluded by !**/package-lock.json
  • examples/type-merging-batching/example.tar.gz is excluded by !**/*.gz
  • examples/type-merging-batching/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (17)
  • examples/apq-subgraphs/package.json (1 hunks)
  • examples/extra-fields/package.json (1 hunks)
  • examples/federation-example/package.json (1 hunks)
  • examples/federation-mixed/package.json (1 hunks)
  • examples/federation-subscriptions-passthrough/package.json (2 hunks)
  • examples/file-upload/package.json (1 hunks)
  • examples/hmac-auth-https/package.json (1 hunks)
  • examples/interface-additional-resolvers/package.json (1 hunks)
  • examples/json-schema-subscriptions/package.json (1 hunks)
  • examples/openapi-additional-resolvers/package.json (1 hunks)
  • examples/openapi-arg-rename/package.json (1 hunks)
  • examples/openapi-javascript-wiki/package.json (1 hunks)
  • examples/openapi-subscriptions/package.json (1 hunks)
  • examples/operation-field-permissions/package.json (1 hunks)
  • examples/programmatic-batching/package.json (1 hunks)
  • examples/subscriptions-with-transforms/package.json (1 hunks)
  • examples/type-merging-batching/package.json (1 hunks)
✅ Files skipped from review due to trivial changes (16)
  • examples/programmatic-batching/package.json
  • examples/file-upload/package.json
  • examples/openapi-additional-resolvers/package.json
  • examples/openapi-subscriptions/package.json
  • examples/federation-example/package.json
  • examples/hmac-auth-https/package.json
  • examples/apq-subgraphs/package.json
  • examples/federation-mixed/package.json
  • examples/extra-fields/package.json
  • examples/type-merging-batching/package.json
  • examples/operation-field-permissions/package.json
  • examples/interface-additional-resolvers/package.json
  • examples/subscriptions-with-transforms/package.json
  • examples/openapi-arg-rename/package.json
  • examples/openapi-javascript-wiki/package.json
  • examples/json-schema-subscriptions/package.json
🧰 Additional context used
📓 Path-based instructions (1)
examples/federation-subscriptions-passthrough/package.json (2)

Pattern examples/**: In this directory we keep all the examples. Examples are generated using a scheduled CI pipeline.
When changes are made to Gateway config, we expect to see some changes in the examples directory.


Pattern **: For all PRs, we would like to verify that a Linear issue is linked. Check if there's a mention for "GW-*" in the PR description, and the us know when it's missing.

In most cases, when a PR adds a new functionality, we would like to make sure it has documentation in the corresponding console project.
Use the global knowledge feature to search for PRs in graphql-hive/console repository that adds documentation. Suggest to create a follow up issue to add the missing documentation.

⏰ Context from checks skipped due to timeout of 90000ms (24)
  • GitHub Check: E2E / Bun Docker on Ubuntu
  • GitHub Check: E2E / Bun on Ubuntu
  • GitHub Check: E2E / Node Binary on Windows
  • GitHub Check: Unit / Node v22
  • GitHub Check: E2E / Node Binary on Ubuntu
  • GitHub Check: E2E / Node Docker on Ubuntu
  • GitHub Check: Leaks / Node v22
  • GitHub Check: Unit / Bun
  • GitHub Check: Benchmark / bun / 1000 items
  • GitHub Check: E2E / Node 22 on Ubuntu
  • GitHub Check: Benchmark / bun / 100 items
  • GitHub Check: Leaks / Node v20
  • GitHub Check: Benchmark / bun / 10 items
  • GitHub Check: Unit / Node v18
  • GitHub Check: Benchmark / node / 1000 items
  • GitHub Check: E2E / Node 20 on Ubuntu
  • GitHub Check: Benchmark / node / 100 items
  • GitHub Check: Build
  • GitHub Check: Leaks / Node v18
  • GitHub Check: Benchmark / node / 10 items
  • GitHub Check: Bundle
  • GitHub Check: E2E / Node 18 on Ubuntu
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Mend Security Check
🔇 Additional comments (2)
examples/federation-subscriptions-passthrough/package.json (2)

5-5: Updated Dependency: @graphql-mesh/transport-ws Version Bump
The dependency version is now set to ^1.0.0, representing a major version upgrade. Please verify that any breaking changes introduced in this major release are compatible with the code that consumes this dependency and that the related documentation has been reviewed.


18-18: Updated Dependency: @graphql-hive/gateway Version Bump
The version update from ^1.9.1 to ^1.9.2 is a minor change. This looks good overall; however, please ensure that any examples relying on this dependency continue to work as expected under the new version.

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Linux-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Linux-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for macOS-ARM64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Bun Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.9.3-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16-bun

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Node Docker Image)

The latest changes of this PR are available as image on GitHub Container Registry (based on the declared changesets):

ghcr.io/graphql-hive/gateway:1.9.3-alpha-9d206825bb802b9d4cebc55eaa8bd5e0bd4c5b16

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for macOS-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

@theguild-bot
Copy link
Collaborator Author

🚀 Snapshot Release (Binary for Windows-X64)

The latest changes of this PR are available for download (based on the declared changesets).

Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants