Skip to content

Commit ae0e2c8

Browse files
committed
Allow configuration of websocket by passing configuration fix #157
1 parent d103402 commit ae0e2c8

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/GraphQLConfiguration.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public static class Builder {
120120
private Executor asyncExecutor = Executors.newCachedThreadPool(new GraphQLThreadFactory());
121121
private long subscriptionTimeout = 0;
122122
private ContextSetting contextSetting = ContextSetting.PER_QUERY_WITH_INSTRUMENTATION;
123-
private Supplier<BatchInputPreProcessor> batchInputPreProcessorSupplier = () -> new NoOpBatchInputPreProcessor();
123+
private Supplier<BatchInputPreProcessor> batchInputPreProcessorSupplier = NoOpBatchInputPreProcessor::new;
124124

125125
private Builder(GraphQLInvocationInputFactory.Builder invocationInputFactoryBuilder) {
126126
this.invocationInputFactoryBuilder = invocationInputFactoryBuilder;

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/GraphQLWebsocketServlet.java

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package graphql.kickstart.servlet;
22

3+
import static java.util.Arrays.asList;
34
import static java.util.Collections.singletonList;
45
import static java.util.stream.Collectors.toList;
56

@@ -20,6 +21,7 @@
2021
import java.io.EOFException;
2122
import java.io.IOException;
2223
import java.util.ArrayList;
24+
import java.util.Arrays;
2325
import java.util.Collection;
2426
import java.util.Collections;
2527
import java.util.HashMap;
@@ -192,8 +194,9 @@ public void modifyHandshake(ServerEndpointConfig sec, HandshakeRequest request,
192194
response.getHeaders().put(HandshakeResponse.SEC_WEBSOCKET_ACCEPT, allSubscriptionProtocols);
193195
}
194196
if (!protocol.isEmpty()) {
197+
//noinspection ArraysAsListWithZeroOrOneArgument
195198
response.getHeaders().put(HandshakeRequest.SEC_WEBSOCKET_PROTOCOL,
196-
singletonList(subscriptionProtocolFactory.getProtocol()));
199+
new ArrayList<>(asList(subscriptionProtocolFactory.getProtocol())));
197200
}
198201
}
199202

0 commit comments

Comments
 (0)