Skip to content

bug fix 393 #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2022
Merged

bug fix 393 #399

merged 1 commit into from
Jan 22, 2022

Conversation

bgoodin
Copy link
Contributor

@bgoodin bgoodin commented Dec 10, 2021

A possible change to the GraphQLSingleInvocationInput that will help support the new context in alignment with graphql-java-tools.

See:
graphql-java-kickstart/graphql-java-tools#566

@bgoodin
Copy link
Contributor Author

bgoodin commented Dec 10, 2021

I'm actually not sure that this is addressing the 393 bug anymore. What this is attempting to do is allow for the ability to migrate off of the deprecated DataFetchingEnvironment.getContext() method and use the DataFetchingEnvironment.getGraphQlContext() while still having access to the "custom" context. It's a bit inception-like because it is a context in a context. Perhaps there is a better way to go about this. I'm open to a better way.

This allows me to do something like the following:

final CustomGraphQLContext customGraphQLContext = dataFetchingEnvironment
.getGraphQlContext()
.get(CustomGraphQLContext.class);

@oliemansm
Copy link
Member

@bgoodin Inception like indeed! ;) I'll merge it as a starting point for further enhancements.

@oliemansm oliemansm merged commit cea4114 into graphql-java-kickstart:master Jan 22, 2022
@oliemansm oliemansm added this to the 12.1.0 milestone Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants