If a GraphQLErrorHandler is present, do not override with ExceptionHa…

[pstarritt-evooq]

If a GraphQLErrorHandler is present, do not override with ExceptionHandler factories or DefaultGraphQLErrorHandler.

#379

[oliemansm]

Thanks! Does this break the scenario that #305 intended to solve, or does that use case still work now too?

[pstarritt-evooq]

Thanks! Does this break the scenario that #305 intended to solve, or does that use case still work now too?

No problem :)
I believe it will still work.

If the application does not have a custom implementation of the GraphQLErrorHandler, then upon broadcast of ApplicationReadyEvent (Only once per app with all ErrorHandlers in the ApplicationContext present) - the ErrorHandlerSupplier's errorHandler is null - therefore it would still invoke logic including GraphQLErrorHandlerFactory().create. If they had custom implementation as well then it would have got overridden anyway. So if one had the custom bean, they should remove it as it was not actually used. To sum up: A custom GraphQLErrorHandler implementation bean will be chosen first.