Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Conversation

bsara
Copy link

@bsara bsara commented Nov 17, 2020

made GraphQLSpringServerWebExchangeContext public rather than internal so that it can be referenced by dependent projects

fixes #426

…l so that it can be referenced by dependent projects - fixes graphql-java-kickstart#426
@bsara
Copy link
Author

bsara commented Nov 17, 2020

@oliemansm I can't find in that huge log file why the tests failed in that one check. It seems strange that they would fail too given how minor the change is that I made. Also, this all run successfully locally for me...but I'm running MacOS, not Windows.

@BlasiusSecundus
Copy link

BlasiusSecundus commented Nov 17, 2020

@bsara, the failure has nothing to do with your PR - one of the subscrption-related tests failed because of a timeout (perhaps it was running a bit slowly on the pipeline):

Testing reset > Should work if subscription was stopped. FAILED
    org.opentest4j.AssertionFailedError: Could not initialize test subscription client. No subscription defined?
        at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:43)
        at org.junit.jupiter.api.Assertions.fail(Assertions.java:129)
        at com.graphql.spring.boot.test.GraphQLTestSubscription.init(GraphQLTestSubscription.java:108)
        at com.graphql.spring.boot.test.GraphQLTestSubscription.init(GraphQLTestSubscription.java:92)
        at com.graphql.spring.boot.test.GraphQLTestSubscription.start(GraphQLTestSubscription.java:139)
        at com.graphql.spring.boot.test.GraphQLTestSubscription.start(GraphQLTestSubscription.java:127)
        at com.graphql.spring.boot.test.GraphQLTestSubscriptionResetTest.shouldWorkIfSubscriptionWasAlreadyStopped(GraphQLTestSubscriptionResetTest.java:43)

        Caused by:
        javax.websocket.DeploymentException: The HTTP request to initiate the WebSocket connection to [ws://localhost:50187/subscriptions] failed
            at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:493)
            at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServer(WsWebSocketContainer.java:197)
            at com.graphql.spring.boot.test.GraphQLTestSubscription.initClient(GraphQLTestSubscription.java:367)
            at com.graphql.spring.boot.test.GraphQLTestSubscription.init(GraphQLTestSubscription.java:106)
            ... 4 more

            Caused by:
            java.util.concurrent.TimeoutException: The HTTP upgrade to WebSocket failed but partial data may have been received: Status Code [0], HTTP headers [{}]
                at org.apache.tomcat.websocket.WsWebSocketContainer.processResponse(WsWebSocketContainer.java:816)
                at org.apache.tomcat.websocket.WsWebSocketContainer.connectToServerRecursive(WsWebSocketContainer.java:358)
                ... 7 more

                Caused by:
                java.util.concurrent.TimeoutException
                    at java.base/sun.nio.ch.PendingFuture.get(PendingFuture.java:195)
                    at org.apache.tomcat.websocket.WsWebSocketContainer.processResponse(WsWebSocketContainer.java:813)
                    ... 8 more

A maintainer e. g. @oliemansm can re-run jobs. And maybe that GraphQLTestSubscription needs one more fix...

@oliemansm oliemansm merged commit 2a81f68 into graphql-java-kickstart:master Nov 17, 2020
@oliemansm
Copy link
Member

Thanks @bsara. Merged it since the build failure isn't caused by your change anyway. It sometimes just fails one of the builds and next time it runs just fine. Could be improved a bit.

@oliemansm oliemansm added this to the 8.1.0 milestone Nov 17, 2020
@bsara bsara deleted the bugfix/426-webflux-context-visibility branch November 17, 2020 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't cast to dataFetchingEnvironment.getContext() to graphql.kickstart.spring.GraphQLSpringServerWebExchangeContext
3 participants