This repository was archived by the owner on Dec 19, 2023. It is now read-only.
fix: memory leak due to ReactiveApolloSubscriptionSession not closing #740
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A memory leak was possible because ReactiveApolloSubscriptionSession did not call close on the ReactiveWebSocketSubscriptionSession that it owned.
|
Some tests are failing the "Publish Unit Test Results" step with the following message: Don't think this is related to the code changes. |
|
No, there was apparently a breaking change in the action used there. See PR #737 |
|
@tomas-c Can you pull in the latest changes from master to let it rebuild? The build issues should be fixed now. |
…iptions-not-closed
|
@oliemansm Yup, merged with latest master and checks are passing now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A memory leak is possible because ReactiveApolloSubscriptionSession does not call close on the ReactiveWebSocketSubscriptionSession that it owns.
Currenctly ReactiveSubscriptionWebSocketHandler calls ReactiveApolloSubscriptionSession.close here. As ReactiveApolloSubscriptionSession does not override the default implementation this call falls back to DefaultSubscriptionSession.close.