Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Update Reflections to 0.10.2 #772

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Update Reflections to 0.10.2 #772

merged 1 commit into from
Jan 22, 2022

Conversation

dheid
Copy link

@dheid dheid commented Dec 29, 2021

Has Guava version 20 dependency which is affected by CVE-2018-10237

@BlasiusSecundus
Copy link

Dependency updates are handled by Renovate bot. However, Reflections is manually restricted to 0.9.11 (https://github.com/graphql-java-kickstart/renovate-config/blob/main/default.json#L24) because 0.9.12 has some issues / bugs making it incompatible with this library.

I just tested with the latest version of Reflections (0.10.2) and that one seems to work, all tests pass.

So perhaps that Renovate restriction can be lifted (cc @setchy / @oliemansm).

@dheid
Copy link
Author

dheid commented Dec 31, 2021

Thank you very much, @BlasiusSecundus ! I updated the pull request according to your statement.

@BlasiusSecundus
Copy link

@dheid thanks. Can you please squash the two commits, and update the commit message so that it passes commitlint (e. g. chore: use Reflections 0.10.2)

@dheid dheid changed the title Update Reflections to 0.9.12 Update Reflections to 0.10.2 Dec 31, 2021
@dheid
Copy link
Author

dheid commented Dec 31, 2021

@BlasiusSecundus Done

@BlasiusSecundus
Copy link

Please also update the commit message.

@dheid
Copy link
Author

dheid commented Dec 31, 2021

@BlasiusSecundus Sorry, I read over. Now the commit message should fit as well.

@BlasiusSecundus BlasiusSecundus added the dependencies Pull requests that update a dependency file label Dec 31, 2021
@oliemansm oliemansm merged commit e684613 into graphql-java-kickstart:master Jan 22, 2022
@oliemansm oliemansm added this to the 12.0.1 milestone Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants