Skip to content

Fix Automatic-Module-Name by replacing dashes with dots to support Java 9+ Module Projects #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tetv opened this issue Apr 25, 2022 · 1 comment
Closed

Fix Automatic-Module-Name by replacing dashes with dots to support Java 9+ Module Projects #60

tetv opened this issue Apr 25, 2022 · 1 comment

Comments

@tetv
Copy link

tetv commented Apr 25, 2022

Describe the bug
Automatic-Module-Name with dashes in the MANIFEST.MF:
Automatic-Module-Name: graphql-java-extended-scalars

Fix: It should contain dots instead of dashes.

To Reproduce
Create a Java 9+ project with modules activated (module-info.java file present).
Although you can ddd the graphql-java-extended-scalars dependency, you won't be able to use it.

Note that the graphql-java project doesn't have this issue, as contains in the Automatic-Module-Name: graphql.java
@tetv tetv changed the title Fix Automatic-Module-Name by replacing dashes with dots to support Java Modularisation Fix Automatic-Module-Name by replacing dashes with dots to support Java 9+ Module Projects Apr 25, 2022
lkorth added a commit to lkorth/graphql-java-extended-scalars that referenced this issue Jun 8, 2022
@lkorth
Fix invalid Automatic-Module-Name
2b366f2 
`-` is invalid in the `Automatic-Module-Name`

Related PRs: graphql-java/java-dataloader#104, graphql-java/graphql-java#2423

Fixes graphql-java#60
This was referenced Jun 8, 2022
Closed
Closed
@dondonz dondonz mentioned this issue Sep 22, 2022
Merged
@dondonz
Copy link
Member

dondonz commented Sep 25, 2022

Closed by #79

@dondonz dondonz closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tetv @dondonz