Skip to content

Conversation

kiendang
Copy link
Contributor

@kiendang kiendang commented Aug 5, 2023

We have this in our workflows

on: [push, pull_request]

This is redundant since when someone pushes to a PR branch, it triggers both push and pull_request synchronized which makes the action runs twice. Checking every PR CI and you will see we have the every check run twice (push) and (pull_request).

Just on: push is enough.

Copy link
Collaborator

@sjdemartini sjdemartini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

@kiendang
Copy link
Contributor Author

kiendang commented Aug 5, 2023

Just learned that the reason for on: [push, pull_request] is that push does not trigger for PRs from forks (graphql-python/graphql-server#117 (review)). I've fixed this, but put in a new PR #1443 from my fork so we can test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants