Skip to content

Unicode support #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miracle2k opened this issue Oct 12, 2015 · 3 comments
Closed

Unicode support #21

miracle2k opened this issue Oct 12, 2015 · 3 comments

Comments

@miracle2k
Copy link

I scalars.py, this line:

def coerce_string(value):
    if isinstance(value, bool):
        return 'true' if value else 'false'
    return unicode(value)

If the input value of a mutation is a unicode string, I get a decode error. A simple fix, unicode(value) handles this for me.

miracle2k added a commit to miracle2k/graphql-core that referenced this issue Oct 12, 2015
@jhgg
Copy link
Member

jhgg commented Oct 12, 2015

Hey. Can you provide code to repro the case where this happens, so we can put it in as a unittest?

Thanks!

@syrusakbary
Copy link
Member

I think the "If the input value of a mutation is a unicode string" is the test case ;)

@jhgg
Copy link
Member

jhgg commented Oct 13, 2015

It shouldn't though. Which is why I'm wondering what's causing the error.

@jhgg jhgg closed this as completed in 87eb526 Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants