Skip to content

Implement Remaining Utilities #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
11 tasks done
jhgg opened this issue Oct 6, 2015 · 9 comments
Closed
11 tasks done

Implement Remaining Utilities #5

jhgg opened this issue Oct 6, 2015 · 9 comments
Assignees
@jhgg
Milestone
v0.4.7

Comments

@jhgg
Copy link
Member

jhgg commented Oct 6, 2015

In https://github.com/graphql/graphql-js/tree/master/src/utilities

Porting Guide

Remaining utilities.
@jhgg jhgg added this to the v0.1 milestone Oct 6, 2015
@syrusakbary
Copy link
Member

I will help you here soon!
We should create a branch for this ;)

@gabriel-laet
Copy link
Contributor

I started a PR related to instrospectionQuery here: dittos/graphqllib#70

@jhgg
Copy link
Member Author

jhgg commented Oct 6, 2015

I don't think it will merge cleanly as we moved utils around in #1.

@jhgg
Copy link
Member Author

jhgg commented Oct 6, 2015

valueFromAst was implemented (by finding it) in values.py on 55dcd92.

@jhgg
Copy link
Member Author

jhgg commented Oct 7, 2015

@gabriel-laet - I ported your PR.

jhgg added a commit that referenced this issue Oct 7, 2015
@jhgg
Move is_valid_value to utilities to match graphql-js reference im…
a68d134 
…plementation.

* Correct syntax in `get_variable_value`'s error messages.
* When using `coerce_value` on a `GraphQLInputObjectType`, it should not populate nullable values into the return value.

#5
@jhgg jhgg mentioned this issue Oct 8, 2015
Closed
11 tasks
@gabriel-laet
Copy link
Contributor

@jhgg Great! I will try to tackle one of the remaining items on this list tomorrow.

@jhgg
Copy link
Member Author

jhgg commented Oct 8, 2015

Awesome thanks! Post here when you start. I had planned to ko the rest of these as well tomorrow. Don't wanna duplicate any effort!

@jhgg
Copy link
Member Author

jhgg commented Oct 8, 2015

Working on buildASTSchema and buildClientSchema

jhgg added a commit that referenced this issue Oct 8, 2015
@jhgg
Implement build_ast_schema utility #5
fe3a31b
jhgg added a commit that referenced this issue Oct 8, 2015
@jhgg
Implement get_operation_ast utility
5b190d3 
#5
@jhgg jhgg self-assigned this Oct 9, 2015
@jhgg jhgg removed the help wanted label Oct 12, 2015
@jhgg jhgg mentioned this issue Oct 13, 2015
Closed
51 tasks
jhgg added a commit that referenced this issue Oct 16, 2015
@jhgg
Implement build_client_schema utility #5
e31a703 
* Implement unit tests for `build_client_schema`.
* Implement `__eq__` methods on `GraphQLEnumValue`, `ExecutionResult`.
@jhgg
Copy link
Member Author

jhgg commented Oct 16, 2015

All utilities + tests have been implemented..

@jhgg jhgg closed this as completed Oct 16, 2015
syrusakbary pushed a commit that referenced this issue Oct 6, 2018
@dfee @Cito
Fixed the subscription race condition (#5)
49e7124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhgg jhgg

Labels
None yet
Projects
None yet
Milestone
v0.4.7
Development

No branches or pull requests
3 participants
@gabriel-laet @syrusakbary @jhgg