Skip to content

FIX #235: change RX requirements to a version below 3.0 #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

FIX #235: change RX requirements to a version below 3.0 #236

wants to merge 1 commit into from

Conversation

Nabellaleen
Copy link

Fix #235

@Nabellaleen
Copy link
Author

Maybe we should apply this fix to older graphql-core versions

ProjectCheshire
ProjectCheshire reviewed Mar 27, 2019
View reviewed changes
Copy link
Member

@ProjectCheshire ProjectCheshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to drop the greater than 1.6.0? I would assume we want gte 1.6.0 and lt 3.0.0

dan98765
dan98765 requested changes Mar 27, 2019
View reviewed changes
@jeremytubbs jeremytubbs mentioned this pull request Jul 17, 2019
Closed
@Cito
Copy link
Member

Cito commented Jul 18, 2019

Thank you all. This is now fixed in version 2.2.1.

@Cito Cito closed this Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmileyChris SmileyChris SmileyChris left review comments

@Cito Cito Cito left review comments

@jeremytubbs jeremytubbs jeremytubbs left review comments

@ProjectCheshire ProjectCheshire ProjectCheshire left review comments

@dan98765 dan98765 dan98765 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RX dependancy conflict for Python 2.7
6 participants
@Nabellaleen @Cito @SmileyChris @jeremytubbs @ProjectCheshire @dan98765