You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is some debugging information that is getting outputted in the graphql_input_object macro namely on line 70. Either, logging framework like Slog or Log should be used for outputting debugging information or this line and others like it should be removed.
I think that all println! not in tests or the example should be removed - I probably accidentally committed them :)
It might be a good idea to support e.g. Slog in the executor, just so that an application developer can get a useable trace from Juniper if they're trying to debug field execution or something.
Not gonna promise anything as I might overload on turkey, but I'll try to get this done on the weekend. @theduke, @mhallin or @LegNeato any strong opinions on what should be logged? I guessing we should use Slog as that looks like to be the de facto for logging.
Activity
mhallin commentedon May 17, 2017
I think that all
println!
not in tests or the example should be removed - I probably accidentally committed them :)It might be a good idea to support e.g. Slog in the executor, just so that an application developer can get a useable trace from Juniper if they're trying to debug field execution or something.
piperRyan commentedon Oct 4, 2018
Not gonna promise anything as I might overload on turkey, but I'll try to get this done on the weekend. @theduke, @mhallin or @LegNeato any strong opinions on what should be logged? I guessing we should use Slog as that looks like to be the de facto for logging.
graysonarts commentedon Feb 20, 2019
@piperRyan - did you end up making any progress on this? I was looking for a way to contribute and this seemed like a good path
piperRyan commentedon Feb 22, 2019
@RussTheAerialist Unfortunately I have been quite busy, so if you wanted to tackle this one you can go ahead! :)
theduke commentedon Aug 30, 2019
Continued in #423 .