Skip to content

Leverage Slog And Or Log For Debugging Output #48

@TheServerAsterisk

Description

@TheServerAsterisk
Contributor

There is some debugging information that is getting outputted in the graphql_input_object macro namely on line 70. Either, logging framework like Slog or Log should be used for outputting debugging information or this line and others like it should be removed.

Activity

mhallin

mhallin commented on May 17, 2017

@mhallin
Member

I think that all println! not in tests or the example should be removed - I probably accidentally committed them :)

It might be a good idea to support e.g. Slog in the executor, just so that an application developer can get a useable trace from Juniper if they're trying to debug field execution or something.

self-assigned this
on Aug 29, 2017
added this to the 1.0 milestone on Aug 29, 2017
piperRyan

piperRyan commented on Oct 4, 2018

@piperRyan
Contributor

Not gonna promise anything as I might overload on turkey, but I'll try to get this done on the weekend. @theduke, @mhallin or @LegNeato any strong opinions on what should be logged? I guessing we should use Slog as that looks like to be the de facto for logging.

graysonarts

graysonarts commented on Feb 20, 2019

@graysonarts

@piperRyan - did you end up making any progress on this? I was looking for a way to contribute and this seemed like a good path

piperRyan

piperRyan commented on Feb 22, 2019

@piperRyan
Contributor

@RussTheAerialist Unfortunately I have been quite busy, so if you wanted to tackle this one you can go ahead! :)

removed this from the 1.0 milestone on May 16, 2019
theduke

theduke commented on Aug 30, 2019

@theduke
Member

Continued in #423 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @graysonarts@theduke@LegNeato@mhallin@TheServerAsterisk

    Issue actions

      Leverage Slog And Or Log For Debugging Output · Issue #48 · graphql-rust/juniper