Apply type condition in inline fragments to fix panic when using inline fragments with interfaces #816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Converting to draft to fix test failures and add a new tests making sure this doesn't regress) |
tyranron
requested changes
Dec 9, 2020
There was a problem hiding this comment.
@LukasKalbertodt thanks for the effort! ❤️
You've changed the async_await.rs file, so fixed the async resolution. But there is still a sync resolution which behaves the old way. It would be nice to fix stuff there too.
This fixes a panic when using inline fragments with interfaces (graphql-rust#815)
`type_name` was already forwarded to `QueryT`, so I guess `concrete_type_name` should be forwarded as well. `RootNode` is an "object" anyway and those should implement the method.
LukasKalbertodt
force-pushed
the
fix-interface-inline-fragment-panic
branch
from
f8700f0 to
9d8f2a3
Compare
LukasKalbertodt
force-pushed
the
fix-interface-inline-fragment-panic
branch
from
9d8f2a3 to
4c9071c
Compare
|
Sorry for opening the PR without running the test. Now it seems to be fine. I fixed it for the sync code, too. And I added a test. Let me know if I can improve anything! |
tyranron
approved these changes
Dec 9, 2020
|
Thanks for merging and for this amazing response time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #815
Note that I was completely unfamiliar with the code and am still unsure if this is the proper way to solve the problem. It works for me. Let me know if I have to change more stuff, if I should fix the bug at a different place in code or whether I should change anything else.
Thanks!