Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

mention CDN in README #510

@odigity

Description

@odigity

I was looking at the package.json to learn about dependencies and was surprised to not see graphiql listed, since I know express-graphql can serve graphiql out-of-the-box.

So, I searched the repo and discovered it's served via links to cdn.jsdelivr.net based on a version number hard-coded in the express-graphql source:

https://github.com/graphql/express-graphql/blob/3412b88186055b275e9da78dc17e501646e9d4c7/src/renderGraphiQL.js#L30
https://github.com/graphql/express-graphql/blob/3412b88186055b275e9da78dc17e501646e9d4c7/src/renderGraphiQL.js#L80

Given that this may have privacy and reliability implications for some people, I suggest explicitly mentioning this in the README.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions