Skip to content

Conversation

IvanGoncharov
Copy link
Member

Motivation #2277

@IvanGoncharov IvanGoncharov added the PR: feature 🚀 requires increase of "minor" version number label Jan 20, 2020
@IvanGoncharov
Copy link
Member Author

@lukejacksonn Big difference for this one and #2277 is that it adds extensions to all imports inside *.mjs files.
I don't really want to add separate *.es.js files since we already generating 4 files for every source file:
image
Do you see any potential problems with publishing both MJS and ESM builds as *.mjs files?

@lukejacksonn
Copy link

Well, that sure simplifies things! I like the idea.. wasn't too sure that importing .mjs still worked in the browser but I just checked and it seems like it does so I can't see there being a problem there.

@IvanGoncharov
Copy link
Member Author

@lukejacksonn Thanks for trying it out 👍
There is still a chance that extensions will break some setups so treat it as an experimental feature and in the worst-case scenario, we will switch to *.es.js files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feature 🚀 requires increase of "minor" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants