Added check for specific symbols in polyfills/symbols #2804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionisnote
force-pushed
the
polyfills-asynciteratable-fix-for-node-8
branch
2 times, most recently
from
fca1cab to
7d4c875
Compare
dionisnote
force-pushed
the
polyfills-asynciteratable-fix-for-node-8
branch
from
7d4c875 to
abcc4b0
Compare
Junoburger
approved these changes
Sep 19, 2020
IvanGoncharov
added
the
PR: bug fix 🐞
|
@dionisnote Thanks for PR 👍 |
tgriesser
added a commit
to tgriesser/graphql-js
that referenced
this pull request
Nov 13, 2020
…ription * master: (211 commits) Update deps (graphql#2844) resources: use named groups in RegExp (graphql#2840) TS: exclude integration tests from root tsconfig.json (graphql#2838) Flow: remove support for measuring Flow coverage (graphql#2837) CI: test on node 15 (graphql#2836) Update deps (graphql#2835) build: add support for experimental releases (graphql#2831) 15.4.0 Update deps (graphql#2827) Update deps (graphql#2825) integrationTests: add Flow test (graphql#2819) fix: ensure variance of types matches how values are used (graphql#2786) Cleanup '__fixtures__' leftovers (graphql#2818) Convert fixtures to be JS files (graphql#2816) Update deps (graphql#2815) benchmark: extract benchmarks into separate folder and run them on NPM package Update deps (graphql#2810) Update outdated documentation (graphql#2806) Make print() break arguments over multiple lines (graphql#2797) Added check for specific symbols in polyfills/symbols (graphql#2804) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for specific symbols in polyfills/symbols because in nodejs 8 Symbol exists, but Symbol.asyncIterator is not.
This cause an error
message: "Subscription field must return Async Iterable. Received: { next: [function next], return: [function return], throw: [function throw], @@asyncIterator: [function] }."just because
isAsyncIterablereturns falseChecking for specific symbols in Symbol will fix it