Visitor does not support enter and leave for the root node
#298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dminkovsky
force-pushed
the
visitor-edit-root-node
branch
from
6456ce4 to
f95bc48
Compare
|
Added a proposed fix. |
|
Thanks so much for detecting and investigating a fix. I'll investigate to add some confidence to the fix, but from first look it appears good. |
dminkovsky
force-pushed
the
visitor-edit-root-node
branch
from
e42e53a to
f79ba42
Compare
|
Thanks Lee. This visitor is really useful. |
sogko
added a commit
to sogko/graphql
that referenced
this pull request
Mar 11, 2016
Commit: f79ba42e30d9f1380f378440e4fe66b1aa428386 [f79ba42] Parents: 4256230557 Author: Dmitry Minkovsky <[email protected]> Date: 21 February 2016 at 6:03:39 AM SGT Commit Date: 21 February 2016 at 12:06:22 PM SGT --- Tests to demonstrate problem Commit: 42562305570b04a5b7ec1ee7714f020f366023c9 [4256230] Parents: 75e7be0028 Author: Dmitry Minkovsky <[email protected]> Date: 21 February 2016 at 5:40:46 AM SGT Commit Date: 21 February 2016 at 12:06:07 PM SGT --- Note: See PR graphql-go#298 for context: graphql/graphql-js#298
mattstern31
pushed a commit
to mattstern31/graphql-gqllero-repository
that referenced
this pull request
Nov 10, 2022
Commit: f79ba42e30d9f1380f378440e4fe66b1aa428386 [f79ba42] Parents: 4256230557 Author: Dmitry Minkovsky <[email protected]> Date: 21 February 2016 at 6:03:39 AM SGT Commit Date: 21 February 2016 at 12:06:22 PM SGT --- Tests to demonstrate problem Commit: 42562305570b04a5b7ec1ee7714f020f366023c9 [4256230] Parents: 75e7be0028 Author: Dmitry Minkovsky <[email protected]> Date: 21 February 2016 at 5:40:46 AM SGT Commit Date: 21 February 2016 at 12:06:07 PM SGT --- Note: See PR #298 for context: graphql/graphql-js#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening an issue to discuss this apparent problem.