-
Notifications
You must be signed in to change notification settings - Fork 2k
diff-npm-package: create reports folder #3623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
this is still actually (sadly) not working, although CI now is. https://github.com/graphql/graphql-js/pull/3623/checks#step:7:7
will try to submit a fix |
never mind, sorry for the error, script doesn't generate a report if no diff is found. on the other hand, the code change is a bit odd, as we are testing to see whether the file is present, and then if not, creating the directory with the path to the file. i guess it is working, but still a bit off. |
graphql#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.
#3623 creates the reports folder via the report path, rather than the reports folder path. This did not trigger an error, because no changes were found.
No description provided.