Skip to content

fix(incrementalDelivery): remove extra then from AsyncRecord completion #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

extracted from #3786

@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Nov 25, 2022
@yaacovCR yaacovCR requested review from robrichard and a team November 25, 2022 07:33
@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit c6f53f7
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63b441abaeee0d0008908463
😎 Deploy Preview https://deploy-preview-3787--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR mentioned this pull request Nov 25, 2022
@yaacovCR yaacovCR force-pushed the remove-extra-then branch 2 times, most recently from 76e6eb9 to 7c6f637 Compare January 3, 2023 14:48
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Jan 5, 2023

Looking back on this. I'm not sure why I extracted this from #3786 -- I think the change that it entails a spec change just as much as the remainder of #3786 and should not be merged separately.

@yaacovCR yaacovCR closed this Jan 5, 2023
@yaacovCR yaacovCR deleted the remove-extra-then branch September 5, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant