-
Notifications
You must be signed in to change notification settings - Fork 64
Use 203 as the partial status code #346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
additional requirements seems to work the best with intermediate servers and | ||
clients, but since it does not semantically line up we only recommend its usage | ||
alongside the `application/graphql-response+json` media type which makes the | ||
meaning explicit. We hope to one day move to `294` if someone can push it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there already work around code 294
? A quick search didn't yield any results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only what I’ve previously proposed, which has been overwritten by this. Just a new status code really. “94” being “PA” for PArtial 🤷♂️
If the _GraphQL response_ contains both the {data} entry (even if it is {null}) | ||
and the {errors} entry, then the server SHOULD reply with `203` status code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if a specific header could be added (but not sure which one!) instead of re-using a status code with a different meaning.
My only concern is that intermediaries may interpret 203
in unexpected ways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(removed, discussed later in the RFC text anyways)
[IETF RFC2616 Section 6.1.1](https://datatracker.ietf.org/doc/html/rfc2616#section-6.1.1) | ||
states "codes are fully defined in section 10" implying that though more codes | ||
are expected to be supported over time, valid codes must be present in this | ||
document. For compatibility reasons, using HTTP status `203` which has no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it needs to be read like that.
Later in section 6.1.1, they keep an open door for extension:
HTTP status codes are extensible. HTTP applications are not required
to understand the meaning of all registered status codes, though such
understanding is obviously desirable. However, applications MUST
understand the class of any status code, as indicated by the first
digit, and treat any unrecognized response as being equivalent to the
x00 status code of that class, with the exception that an
unrecognized response MUST NOT be cached. For example, if an
unrecognized status code of 431 is received by the client, it can
safely assume that there was something wrong with its request and
treat the response as if it had received a 400 status code. In such
cases, user agents SHOULD present to the user the entity returned
with the response, since that entity is likely to include human-
readable information which will explain the unusual status.
Additional status codes that are not part of section 10 are defined in RFC 6585, which officially Updates: 2616
.
But new status codes are also defined outside of the scope of 2616
, e.g. status code 207
is defined in RFC4918 without any mention of "updating" RFC 2616
, it's only referenced in different context there.
So, going by that, we wouldn't necessarily be restricted to the RFC 2616 status codes - but of course, introducing a new one might bring it's own risk.
That said, RFC 4918 reads to me like it only applies to very specific contents types, so maybe 207
with a different content type might actually not provoke a conflict?
A Multi-Status response conveys information about multiple resources
in situations where multiple status codes might be appropriate. The
default Multi-Status response body is a text/xml or application/xml
HTTP entity with a 'multistatus' root element. Further elements
contain 200, 300, 400, and 500 series status codes generated during
the method invocation. 100 series status codes SHOULD NOT be recorded
in a 'response' XML element.
My thoughts: 203 Non-Authoratative InformationBenefits:
Cons:
206 Partial ContentBenefits:
Cons:
207 Multi-StatusBenefits:
Cons:
294 Partial Response (or another GraphQL-defined code)Benefits:
Cons:
|
It should be noted that since most all requests will be HTTPS, the above firewall considerations only apply to application-level firewalls (Secure Web Gateway), as regular firewalls would not have access to the response code. |
I would select 207 because its exact description matches our use case. But first I would prefer to see some testing with commonly used Secure Web Gateways. I wouldn't worry about server-end proxies because the GraphQL server operator would set that up as needed (which may include changing the response code of the GraphQL server to always be 200). And the use of Secure Web Gateways are probably limited to large companies or governments which are likely enough to have a team ready to allow (or disallow) access to specific websites. So testing becomes less important. The only leaves other proxies, such as a cell provider might install to make their network appear faster, which I don't think proxies would be an issue with 207. So I'd go with 207. (Just my two cents.) 203 is probably the "safest" choice.... |
Note that 201/202 also are as "safe" of a selection as 203, perhaps moreso. But again, the meaning doesn't carry over to GraphQL's intended use at all. |
See changes for explanation.
Note: this will need testing before we can merge it.