Skip to content

Cannot scroll through the result pane of an subscription #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 7 tasks
iagobruno opened this issue Apr 30, 2019 · 16 comments · Fixed by #1023
Closed
1 of 7 tasks

Cannot scroll through the result pane of an subscription #1021

iagobruno opened this issue Apr 30, 2019 · 16 comments · Fixed by #1023

Comments

@iagobruno
Copy link
Contributor

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

Windows 10

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.7.x

What is the expected behavior?

Can scroll the result panel to see all events.

What is the actual behavior?

When I try to use the mouse wheel nothing happens.

What steps may we take to reproduce the behavior?

Just make a simple subscription query and get some events to see the problem.

Idea of how to solve the problem:

Currently the result panel has height: auto, you have to do the height calculation that the panel should have using javascript when the app is mounted or make the editor container have the height you want/possible and make the result panel have height: 100%.

@loudmouth
Copy link

Also experiencing this problem.

@phanatuan
Copy link

Me too!

@yoshiakis yoshiakis added bug/1-repro-available A reproduction exists and needs to be confirmed. kind/bug labels May 24, 2019
@yoshiakis yoshiakis added bug/2-confirmed and removed bug/1-repro-available A reproduction exists and needs to be confirmed. labels Jun 3, 2019
@ksugiarto
Copy link

No update on this issue? Then how did you guys use this for Subscription all this long? Any workaround?

@smeijer
Copy link

smeijer commented Oct 21, 2019

Any workaround?

F5

@iagobruno
Copy link
Contributor Author

iagobruno commented Oct 21, 2019

For now, the only solution is install an extension to inject this css into localhost pages.

.graphiql-wrapper>div:first-child>div:first-child>div:nth-child(2) {
  height: 100%;
}
.graphiql-wrapper>div:first-child>div:first-child>div:nth-child(2)>div:nth-child(2) {
  height: 100%;
  overflow-anchor: auto;
}

@smeijer
Copy link

smeijer commented Oct 22, 2019

@iagobruno , I can recommend adding display: flex and flex-direction: column-reverse to that snippet, to inverse the direction. This way you'll always have the most recent data on top. Making it unnecessary to scroll:

display: flex;
flex-direction: column-reverse;

@iagobruno
Copy link
Contributor Author

@smeijer I tested your recommendation but it causes a scrollbar bug when a new result is added (I have no idea why), but the overflow-anchor property will make the last added item always visible if you scroll to extreme bottom.

@vojtapol
Copy link

vojtapol commented Nov 6, 2019

This is broken in GraphQL Playground HTML too. Any idea how to temporarily fix it there?

@vizo
Copy link

vizo commented Feb 18, 2020

Anything new on this?

@fitalefi
Copy link

+1

1 similar comment
@adrianoresende
Copy link

+1

@acao acao closed this as completed in #1023 Apr 3, 2020
@arnasledev
Copy link

still a problem..

@AkashRajpurohit
Copy link

Why is the issue closed, still facing this issue

@beeman
Copy link
Contributor

beeman commented Jun 24, 2020

The scrolling issue is fixed in this version, however it is very possible that the GraphQL server you are using is using a different version of this library. I know that for instance Apollo maintains their own for which still has the bug.

@AkashRajpurohit
Copy link

The scrolling issue is fixed in this version, however it is very possible that the GraphQL server you are using is using a different version of this library. I know that for instance Apollo maintains their own for which still has the bug.

@beeman Yes, I am using Apollo maybe that's why the issue still persists in the playground version there.

Can you tell me where should I reach for to get this issue solved?

@smeijer
Copy link

smeijer commented Jun 25, 2020

The apollo-server repo.

https://github.com/apollographql/apollo-server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.