-
Notifications
You must be signed in to change notification settings - Fork 736
Add ability to set subscription timeout via config #1247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Also here: there's a 1000 ms limit to making the connection. I recently moved to the other side of the world, and was wondering why my subscriptions are broken 🤦 |
I am facing an issue when using AWS Api Gateway with Lambda behind it. Cold starts sometimes exceed 1000ms, making the subscription fail. I think I'll create a PR for this. |
Actually, after doing some more research, it looks like the issue three-folded.
|
Forcing timeout to be set value by setting both timeout and minTimeout on the subscription client
This would help fix an issue where if the GraphQL server using |
@sungam3r I was having trouble testing a new GraphQL.NET server implementation with a 25sec keep-alive timer because Playground (and/or The current GraphQL.NET Server implementation does not send keep-alive packets at all. Note that Playground does not appear to support the newer Link to GraphQL.Net Server: |
It would be ideal if the middleware configuration and the defaultLinkCreator supported passing an override for the SubscriptionClient timeout instead of having it hard coded to 20000 as shown here:
https://github.com/prisma-labs/graphql-playground/blob/fa91e1b6d0488e6b5563d8b472682fe728ee0431/packages/graphql-playground-react/src/state/sessions/fetchingSagas.ts#L81
The text was updated successfully, but these errors were encountered: