Skip to content

Setting shareEnabled to false does not disable the share button. #860

@andreduvoisin

Description

@andreduvoisin

This issue pertains to the following package(s):

  • GraphQL Playground - Electron App
  • GraphQL Playground HTML
  • GraphQL Playground
  • GraphQL Playground Express Middleware
  • GraphQL Playground Hapi Middleware
  • GraphQL Playground Koa Middleware
  • GraphQL Playground Lambda Middleware

What OS and OS version are you experiencing the issue(s) on?

Windows 10 Version 1709 (OS Build 16299.666)
Google Chrome Version 70.0.3538.67 (Official Build) (64-bit)

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

1.7.0 and 1.8.0

What is the expected behavior?

"Share Playground" button is disabled.

What is the actual behavior?

"Share Playground" button is enabled.

What steps may we take to reproduce the behavior?

Set shareEnabled: false in GraphQLPlayground.init() for the HTML version of Playground.

Exact options I'm running:

GraphQLPlayground.init(root, {
    endpoint: '/api/graphql',
    shareEnabled: false
})

Current workaround is to disable in the CSS, but since this changes per version, it's a bit of a struggle. In 1.8.0 this is:

.sc-hqyNC.bqVjBc {
    display: none;
}

Please provide a gif or image of the issue for a quicker response/fix.

shareenabledbug

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions