Correctly use cookies when fetching schema #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation currently fails to send cookies along with a request (even though that was intended). This is because `credentials: include` is included in the list of headers rather than being passed as an option. Fixes graphql#505
|
|
|
Can we get this PR soon, please? That will be really helpful. Thanks! |
|
@timsuchanek can you get this on the fast track? 🚀 |
|
Thanks for the PR @tekacs ! Just merged it :) |
|
Thank you, guys! May I ask when will we release this? |
|
Out right now! |
RenovZ
pushed a commit
to RenovZ/graphql-playground
that referenced
this pull request
Mar 25, 2022
This implementation currently fails to send cookies along with a request (even though that was intended). This is because `credentials: include` is included in the list of headers rather than being passed as an option. Fixes graphql#505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation currently fails to send cookies along with a request (even though that was intended).
This is because
credentials: includeis included in the list of headers rather than being passed as an option.Fixes #505
Changes proposed in this pull request:
credentials: includefrom improperly being sent in headers to being passed as an option when fetching schema.