Skip to content

renderPlaygroundPage - cdnUrl config option #845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2018
Merged

renderPlaygroundPage - cdnUrl config option #845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8906fb
renderPlaygroundPage - cdnUrl config option
Sep 24, 2018
a364499
don't insert @ in cdn url if no version given
Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions packages/graphql-playground-html/src/render-playground-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ export interface IntrospectionResult {

export interface RenderPageOptions extends MiddlewareOptions {
version: string
cdnUrl?: string
env?: any
}

Expand All @@ -67,15 +68,15 @@ export interface Tab {

const loading = getLoadingMarkup()

const getCdnMarkup = options => `
<link rel="stylesheet" href="//cdn.jsdelivr.net/npm/graphql-playground-react@${
options.version
const getCdnMarkup = ({version, cdnUrl = '//cdn.jsdelivr.net/npm'}) => `
<link rel="stylesheet" href="${cdnUrl}/graphql-playground-react${
version ? `@${version}` : ''
}/build/static/css/index.css" />
<link rel="shortcut icon" href="//cdn.jsdelivr.net/npm/graphql-playground-react@${
options.version
<link rel="shortcut icon" href="${cdnUrl}/graphql-playground-react${
version ? `@${version}` : ''
}/build/favicon.png" />
<script src="//cdn.jsdelivr.net/npm/graphql-playground-react@${
options.version
<script src="${cdnUrl}/graphql-playground-react${
version ? `@${version}` : ''
}/build/static/js/middleware.js"></script>
`

Expand Down