Add contribution guide and code of conduct #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondonz
commented
Oct 23, 2022
| @@ -166,30 +166,3 @@ values for logically identical values. For example a `MyLocalDate` scalar could | |||
| accept the literals `"01-10-2022"` and `"01102022"` as input for the first of | |||
| October 2022, but the result coercion should always return one of the possible | |||
| representations. | |||
|
|
|||
andimarek
reviewed
Nov 2, 2022
| @@ -0,0 +1,49 @@ | |||
| # Contributor Code of Conduct | |||
There was a problem hiding this comment.
I think we should reference here the general GraphQL code of conduct and not introduce a new one.
There was a problem hiding this comment.
Good idea, I'll reference https://graphql.org/codeofconduct/
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| "Author: andimarek" | |||
|
|
|||
| "Date: 18.10.2022" | |||
| "Date: 2022.10.18" | |||
There was a problem hiding this comment.
How about yyyy-mm-dd instead of .?
scalars/new-scalar.md
Outdated
| should be under "scalars/contributed/<your-name>/<scalar-name>.md" | ||
| The goal of the GraphQL Scalars project is to provide a directory of GraphQL | ||
| Custom Scalar specifications, contributed by the community. Contributed | ||
| specifications will be hosted on a GraphQL Foundation owned domain, which can be |
There was a problem hiding this comment.
We should be specific and name the domain scalars.graphql.org
| available reference documents. We will permit small edits which do not change | ||
| specification semantics, such as typo fixes. | ||
|
|
||
| A new version of a Custom Scalar specification should have a new scalar name, |
There was a problem hiding this comment.
or just a completely different name like OffsetDateTime vs DateTime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
After merging this PR, the remaining two items are: deciding on license and connecting to the GraphQL Foundation domain.