Fix operator precedence in test:format #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yaacovCR
force-pushed
the
fix-op-precedence
branch
2 times, most recently
from
42070d4 to
0b49f6b
Compare
yaacovCR
force-pushed
the
fix-op-precedence
branch
from
0b49f6b to
7a755ef
Compare
this isn't perfect, as on my windows bash shell we don't get the error message, but i guess is better, because at least the behavior is correct. on my machine, it works with curly braces or brackets, but that doesn't work on ci, which seems to want parantheses, which gives the incorrect behavior on my machine!
|
Issue was introduced in b9fad9b |
benjie
previously requested changes
Jan 13, 2023
benjie
changed the title
|
Til. Thanks for the quick fix folks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this question and answer about the sometimes-surprising behavior of logical operator precedence in Bash as a reference.