Skip to content

[2021-05-13] Raise a GraphQL.js PR for preventing @skip/@include on subscriptions #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benjie opened this issue Jun 1, 2021 · 3 comments
Closed

[2021-05-13] Raise a GraphQL.js PR for preventing @skip/@include on subscriptions #695

benjie opened this issue Jun 1, 2021 · 3 comments
Assignees
@benjie
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@benjie
Copy link
Member

benjie commented Jun 1, 2021

Potential validation oversight - @skip/@include; see related RFC: graphql/graphql-spec/pull/860
ACTION - Benjie - raise a separate PR for this against GraphQL.js

Note: Action Item issues are reviewed and closed during Working Group
meetings.
@benjie benjie self-assigned this Jun 1, 2021
@benjie
Copy link
Member Author

benjie commented Nov 28, 2021

From https://github.com/graphql/graphql-wg/blob/main/notes/2021-09-02.md#review-previous-meetings-action-items-5m-lee

Ivan: I can do this Benjie, ping me
[ACTION - Benjie] Ping Ivan about this

@IvanGoncharov PING! 😁

@benjie
Copy link
Member Author

benjie commented Jan 6, 2022

@IvanGoncharov Did you get a chance to look at this?

@benjie benjie added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Oct 9, 2023
@benjie benjie mentioned this issue Oct 9, 2023
Merged
@benjie
Copy link
Member Author

benjie commented Oct 9, 2023

I've raised a PR with a basic implementation: graphql/graphql-js#3974

@benjie benjie closed this as completed Dec 7, 2023
JoviDeCroock pushed a commit to graphql/graphql-js that referenced this issue Mar 7, 2025
@benjie
Forbid @Skip and @include directives in subscription root selection (#…
9080d75 
…3974)

This is an implementation of
graphql/graphql-spec#860

The spec calls for a separate `CollectSubscriptionFields` algorithm due
to executing without `variableValues`; but I figured that maintenance
would be easier with the algorithms synchronized.

Please feel free to make any changes you need to this PR; it's just to
get the ball rolling.

Related GraphQL WG action item (from 2021!):
graphql/graphql-wg#695
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjie benjie

Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjie @IvanGoncharov