Yup i18n #777
Open
Yup i18n #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2025
|
This was referenced May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yup validation system don't provide dynamic locale system. Only the
setLocaleglobal method and field-specificconstraint(msg)exists.The previous way of work to output react-intl key with
setLocaleisn't satisfying because we need to override all standard yup errors (partially done currently), and we need to catch yup error and pass them to react-intl ourself manually.A new way found is to instead pass localized message to Yup during the schema construction. It's more simple to trace from were come the translations keys and we don't have to worry of yup output in components.
Bonus: Include yup-locales library to have French translations for native yup messages.