Unmarshaler for `patternProperties` missing

[sisp]

I can't find an unmarshaler for patternProperties.

[sisp]

patternProperties is not supported by OpenAPI 3.0: OAI/OpenAPI-Specification#687 (comment)

In this case, I think there's nothing to do here. python-oas expects a valid OpenAPI spec file. Even though python-oas can validate patternProperties due to jsonschema, it is not officially supported and data is not unmarshaled based on patternProperties anyway.

Feel free to close this issue if you agree with the above.

[grktsh]

Even though python-oas can validate patternProperties due to jsonschema, it is not officially supported and data is not unmarshaled based on patternProperties anyway.

Thanks, I overlooked this behavior. I'd like to remove patternProperties validator from oas.schema.validators._Validator since it is unsupported feature and it is incomplete behavior that data is validated but is not unmarshaled. What do you think?

[sisp]

I agree that it would be more consistent to not validate patternProperties.

[sisp]

How would you go about removing the validator? jsonschema only seems to have the extend method. After checking the jsonschema source code, I think simply removing the validator from _Validator.VALIDATORS should be safe as _Validator is a custom extension.

_Validator = validators.extend(
    Draft4Validator, {'type': _type_validator, 'enum': _enum_validator}
)

for name in [u'patternProperties']:
    _Validator.VALIDATORS.pop(name)

[grktsh]

Agree. But I think del statement is better than dict.pop since the return value is not used. And I'd like to avoid polluting the namespace with name. How about del _Validator.VALIDATORS['patternProperties']?

[sisp]

LGTM. I can create a PR if you like.

[grktsh]

Could you create it? 🙏

[sisp]

I've created a PR. Let me know what you think.

[grktsh]

I'm going to close this issue for now as explained in the PR.