examples/features/csm_observability: Make CSM Observability example server listen on an IPV4 address #7933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7933 +/- ##
==========================================
+ Coverage 82.08% 82.12% +0.03%
==========================================
Files 379 379
Lines 38230 38230
==========================================
+ Hits 31380 31395 +15
+ Misses 5550 5539 -11
+ Partials 1300 1296 -4 |
|
It probably changed after version bump of |
purnesh42H
approved these changes
Dec 16, 2024
zasweq
added a commit
to zasweq/grpc-go
that referenced
this pull request
Dec 16, 2024
…erver listen on an IPV4 address (grpc#7933)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the example server listen explicitly on IPV4. This was causing issues as sometimes the system would listen on IPV6 in previous state which would not align with the LDS Resource.
RELEASE NOTES: