Split start from newCall, and specify method calling order restrictions. #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| headers.removeAll(GrpcUtil.AUTHORITY_KEY); | ||
| InProcessStream stream = new InProcessStream(); | ||
| stream.serverStream.setListener(clientStreamListener); |
There was a problem hiding this comment.
If this is delayed, then serverTransportListener.streamCreated needs to be delayed, and so clientStream.setListener needs to be delayed, and that causes a race with shutdownStatus, such that it should be delayed. So basically everything should be delayed (it doesn't matter when the headers.removeAll is done, but might as well delay it with everything else).
I think that leaves in this method just new InProcessStream() and some lines to save method and headers.
There was a problem hiding this comment.
Done, using the same style as Netty and OkHttp transports.
|
@zhangkun83 Are the any more outstanding comments? |
| // Volatile to be readable without synchronization in the fast path. | ||
| // Writes are also done within synchronized(this). | ||
| private volatile ClientStream realStream; | ||
| // set to non null once both listener and unstartedStream are valid. After this point it is safe |
There was a problem hiding this comment.
s/unstartedStream/realStream
carl-mastrangelo
changed the title
|
LGTM |
carl-mastrangelo
force-pushed
the
fromPression4
branch
from
e3ab4b5 to
3276442
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fairly large change, with special care taken around synchronization. The main idea of this change is to make it possible to do secondary initialization on the stream before any network traffic happens.