Skip to content

benchmarks: check shutdown after acquiring a token, and weak error messages on shutdown #2399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

carl-mastrangelo
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo commented Nov 2, 2016

This makes the shutdown status checked AFTER acquiring a token, which may take a long time. Tokens are released after a call finished, but acquired after checking the shutdown status. This makes the last calls of the benchmark run always fail loudly. Instead, check after getting the right of way and just give it back if the client is stopping.

Additionally, errors on shutdown aren't really important, and typically are just noise. Weaken them to FINE level if the driver is shutdown.

Updates #2372

@carl-mastrangelo carl-mastrangelo merged commit f6c333e into grpc:master Nov 2, 2016
@carl-mastrangelo carl-mastrangelo deleted the acquireInterruptibly branch November 2, 2016 20:08
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants