benchmarks: check shutdown after acquiring a token, and weak error messages on shutdown #2399
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the shutdown status checked AFTER acquiring a token, which may take a long time. Tokens are released after a call finished, but acquired after checking the shutdown status. This makes the last calls of the benchmark run always fail loudly. Instead, check after getting the right of way and just give it back if the client is stopping.
Additionally, errors on shutdown aren't really important, and typically are just noise. Weaken them to FINE level if the driver is shutdown.
Updates #2372