grpc-js: Fix the final proxy bugs #1381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few more issues:
ChannelCredentials#_getConnectionOptions
was returning a reference to a mutable object, whichSubchannel#createSession
was mutating. I changed both of those lines for defense in depth.In
http_proxy.ts
,getProxiedConnection
was resolving the promise before trying to connect with TLS. That is simply incorrect, and was probably a merge error.Again in
getProxiedConnection
,tls.connect
did not always get aservername
option, which is required to set the SNI request in the TLS handshake. With that change, adding the originalconnectionOptions
needs to be moved to the end so that theservername
option from thegrpc.ssl_target_name_override
channel option takes precedence.I tested this by successfully making a request to the prod interop server using TLS through an
HTTP CONNECT
proxy.