Skip to content

Delete grpc-native-core from master, along with all references #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2020

Conversation

murgatroid99
Copy link
Member

@murgatroid99 murgatroid99 commented May 13, 2020

I also copied some .proto files that were being referenced from the submodule into test/proto.

Output of git grep -- -core:

README.md:Directory: [`packages/grpc-native-core`](https://github.com/grpc/grpc-node/tree/[email protected]/packages/grpc-native-core) (lives in the `[email protected]` branch) (see here for installation information)
packages/grpc-native-core/README.md:The `grpc` npm pacakge previously lived in this package. It has been removed. It now lives in the [`[email protected]` branch](https://github.com/grpc/grpc-node/tree/grpc%401.24.x/packages/grpc-native-core) where bugfixes are still being applied.

In the test directory tests that test all combinations of client and server from both libraries, I removed only the set that uses both the client and server from the native library, and I switched to installing the native library from npm instead of using the local copy. This way, we can still test that grpc-js matches the behavior of grpc, and I think the interop tests should still work.

After/in parallel to this, I think I can easily migrate the grpc-tools build to a GitHub Workflow and remove the Kokoro build tests entirely. I would also like to migrate the regular tests to a GitHub Workflow, but there doesn't seem to currently be a good way to get the per-test reports that we currently have.

@murgatroid99 murgatroid99 requested a review from nicolasnoble May 13, 2020 22:37
@murgatroid99
Copy link
Member Author

It is expected that the Electron build jobs fail, because I deleted those config files and build scripts.

@murgatroid99
Copy link
Member Author

The Windows Build Job has been failing due to an issue that is fixed in #1422. That is probably the reason it is failing here.

The Mac build job config files were also deleted so I expect that to fail too.

@merlinnot
Copy link
Contributor

My offer still stands 🙂 #1170

@murgatroid99
Copy link
Member Author

@merlinnot Do you know how to get good per-test output comparable to what we currently get from Kokoro from GitHub Actions?

@merlinnot
Copy link
Contributor

That looks similar to GitHub annotations. I personally only used that for ESLint before, to annotate errors and warnings, but it looks like people are also using it for failed tests:

fail

Did I understand your intention correctly, to have an output with failures only?

@murgatroid99
Copy link
Member Author

Yes, that looks like what I'm looking for: separate reports for each test failure, along with specific output from each test. I found mocha-github-actions-reporter which probably does that, though I'm not entirely sure how it's used.

@murgatroid99 murgatroid99 merged commit 404245a into grpc:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants