Remove grpc sources from grpc++ #21662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veblush
added
lang/core
release notes: no
|
grpc_build_artifacts_multiplatform: passed. |
muxi
approved these changes
Jan 15, 2020
lidavidm
added a commit
to lidavidm/arrow
that referenced
this pull request
Jan 17, 2020
gRPC 1.26.0 is broken due to multiple definitions of the same symbol. For now, build with bundled gRPC. grpc/grpc#21662
lidavidm
added a commit
to lidavidm/arrow
that referenced
this pull request
Jan 17, 2020
gRPC 1.26.0 is broken due to multiple definitions of the same symbol. For now, build with bundled gRPC. grpc/grpc#21662
yashykt
referenced
this pull request
Aug 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's test this out. This is a rollback of commit in #20988, which introduced the ODR violation which causes an undefined behavior, in this case, segfault in trying to initialize the same global variable multiple times.
Related with #21213.