xds-k8s: Fix incorrect type hint in the baseline test #29577
Conversation
sergiitk
added
the
release notes: no
|
Did a manual test run of this single test, all passed. |
| with self.subTest('7_start_test_client'): | ||
| test_client = self.startTestClient(test_servers[0]) | ||
| test_client: _XdsTestClient = self.startTestClient(test_server) |
There was a problem hiding this comment.
Let's lift the declaration two lines up? Variable "test_client" is expected to be used later in other sub tests.
There was a problem hiding this comment.
IRRC with doesn't create separate variable scope (that's python's quirk) - so declarations inside with are equivalent to the declarations outside.
There was a problem hiding this comment.
There was a problem hiding this comment.
No strong opinion here. Asking this because #29476 (comment).
There was a problem hiding this comment.
Oh - that comment was referring to breaking it for readability - otherwise the line break made it less readable.
There was a problem hiding this comment.
Then I completely misunderstood that 🤦 I thought it's about variable type annotation.
copybara-service
bot
added
the
imported
Minor fix: noticed test_servers should've been a
List[_XdsTestServer], but instead of fixing the type I renamed the variable fromtest_serverstotest_serverinstead, and grabbed the first element.