this is not working. because bool(AssertionError) is true

[alanjds]

google#405 opened by @rishatik92 on Jun 6

https://github.com/google/grumpy/blob/3ec87959189cfcdeae82eb68a47648ac25ceb10b/testing/list_test.py#L53

[alanjds]

Sorry @rishatik92, I do not understand what is wrong:

$ python -c 'print bool(AssertionError)'
True
$ grumpy -c 'print bool(AssertionError)'
True

This seems just right. Can you elaborate please?

[rishatik92]

i was just want to say that assert AssertionError - will never raised because:

>> bool(AssertionError) True

пн, 3 сент. 2018 г. в 1:52, Alan Justino da Silva <[email protected]

…

: Sorry @rishatik92 <https://github.com/rishatik92>, I do not understand what is wrong: $ python -c 'print bool(AssertionError)' True $ grumpy -c 'print bool(AssertionError)' True This seems just right. Can you elaborate please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC91rdIpj_EAMFHrzMHwX4VRO6qgnzMjks5uXGE6gaJpZM4WE_UO> .

[alanjds]

I see. It looks to be testing if the list exceptions are being raised correctly. The test should be doing assert False, 'an exception should raise on previous line', not assert AssertionError.

Thanks for pointing

[rishatik92]

)) glad to help пн, 3 сент. 2018 г. в 16:54, Alan Justino da Silva <[email protected]

…

: I see. It looks to be testing if the list exceptions are being raised correctly. The test should be doing assert False, 'an exception should raise on last line, not assert AssertionError. Thanks for pointing — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#67 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC91rWtFpwNPhUrdHDr-G127FqU8PLWFks5uXTShgaJpZM4WE_UO> .