-
Notifications
You must be signed in to change notification settings - Fork 18
add c variant for old str formatting #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I see, that it fails. Thinking its due to a different text editor settings. But cant check it locally now. Command 'python setup.py develop' fails with message 'unsupported Go version , Grumpy requires at least 1.9...'. But my go version is go1.10.3 linux/amd64. |
Yeah, but is about formating:
Just run the provided line
Strange. What linux are you using? How you installed Go? Can you please share the output of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I will add a test before merging, but you can do it to make the merge occur sooner.
You can take a look on str_test.go
if possible?
Yes, I wanted to add a test. I got it how the tests work. I'm running on another system now. Further I will understand, why I had problem in windows linux subsystem (Debian). |
Thanks for the test. I wanted to explore the Windows Linux Subsystem too. Good to know that it messed with your Go versions. In theory it should work and no Windows port would be needed at all, but lets see... |
Its important for example for:
print(datetime.now())
And may be checked in this way:
"%c" % 107 # gives letter 'k'
and this:
"%c" % "k" # gives letter 'k' too