Skip to content

Add CI github action #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 3, 2022
Merged

Add CI github action #40

merged 6 commits into from
Jan 3, 2022

Conversation

MalcolmMielle
Copy link
Collaborator

This PR adds a GitHub action to run flutter analyze on push and PR to main for validation. There is no test in the package yet, so the CI doesn't run any test ;).

I have added a similar CI in adwaita and also another action called main.yml to automatically publish the package to pub.dev anytime a new release is published. Let me know if you'd like to set up something similar here,

@prateekmedia
Copy link
Member

prateekmedia commented Jan 3, 2022

Please create the release ci too, Also where would I find my secret credential json?

@MalcolmMielle
Copy link
Collaborator Author

MalcolmMielle commented Jan 3, 2022

The location of the pub-credential depends on your OS. If it's not there, it is in pub-cache, and you should flutter pub logout and flutter pub login again to have it at the right place. Copy it as JSON_CREDENTION secret in the repo.

That say the release action didn't work for me on adwaita yesterday, so I'll be curious to know if it works here :).

@MalcolmMielle
Copy link
Collaborator Author

Release CI added.

@MalcolmMielle MalcolmMielle marked this pull request as draft January 3, 2022 10:33
Minor changes to the Markdown file following markdownlint.
The file start with a header instead of subtitiles.
indentation is 2, and A space is added before lists.
@MalcolmMielle MalcolmMielle marked this pull request as ready for review January 3, 2022 11:11
Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prateekmedia prateekmedia merged commit 1e33bea into main Jan 3, 2022
@prateekmedia prateekmedia deleted the ci branch February 6, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants