Use window.location on logout success #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Redirecting the user on logout will clear the application state - Moved the window.location call to the logout action
derick-montague
force-pushed
the
i-62-reset-state
branch
from
969b712 to
87cb5b6
Compare
There was a problem hiding this comment.
To me it looks like manually setting the window location is forcing a browser refresh, which is clearing the store state, but I'm not understanding why we are setting the location to /logout instead of just refreshing, especially since it isn't a defined route in our application.
yoshiemuranaka
approved these changes
Dec 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redirecting the user on logout will clear the application state